Use pyproject toml - Githubissues

RadioAstronomySoftwareGroup / pyuvsim

A ultra-high precision package for simulating radio interferometers in python on compute clusters.

https://pyuvsim.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

42 stars 6 forks source link

Use pyproject toml #468

Closed bhazelton closed 1 month ago

bhazelton commented 1 month ago

Description

Convert to using pyproject.toml as much as possible. This follows current best practices.

Note: I used the author list from the pyuvsim paper, but I think maybe there are some names we should add, e.g. @steven-murray, maybe others?

Also fixed two things in the actions yaml that seem to have fixed the MacOS builds:

fetching the full-depth repo (without this calls to git describe fail)
calling git describe and git version right before the install step. This seems to fix a problem on Mac builds where setuptools_scm's call to git was timing out. I don't really understand why...

Motivation and Context

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Reference simulation update or replacement
[ ] Documentation change (documentation changes only)
[ ] Version change
[x] Build or continuous integration change

Checklist:

For all pull requests:

[x] I have read the contribution guide.
[x] My code follows the code style of this project.

Build or continuous integration change checklist:

[x] If required or optional dependencies have changed (including version numbers), I have updated the readme to reflect this.
[ ] If this is a new CI setup, I have added the associated badge to the readme and to references/make_index.py (if appropriate).

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (ff9720a) to head (6dfe48a).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #468 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 11 11 Lines 2175 2165 -10 ========================================= - Hits 2175 2165 -10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.