RadioAstronomySoftwareGroup / pyuvsim

A ultra-high precision package for simulating radio interferometers in python on compute clusters.
https://pyuvsim.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
42 stars 7 forks source link

Fixed a bug in run_uvdata_uvsim to ensure correct uvws #476

Closed bhazelton closed 4 months ago

bhazelton commented 4 months ago

Description

Fixes a bug which resulted in incorrect uvws for output UVData object.

Motivation and Context

Fixes #473

Types of changes

Checklist:

For all pull requests:

Bug fix checklist:

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (d24b1c6) to head (710f28c). Report is 26 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #476 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 11 11 Lines 2166 2176 +10 ========================================= + Hits 2166 2176 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bhazelton commented 4 months ago

works for me. Good idea moving some of that finalization into a new function

That refactoring was required because my added if statement made it too complex 😝