RadioAstronomySoftwareGroup / pyuvsim

A ultra-high precision package for simulating radio interferometers in python on compute clusters.
https://pyuvsim.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
43 stars 7 forks source link

perf: allow not running checks #503

Open steven-murray opened 1 month ago

steven-murray commented 1 month ago

Description

Since UVData.new() already runs an object check, we pass the check_kw to it instead of running the object check in _complete_data. The object check actually takes a somewhat significant amount of time (because it has to recompute all the LSTs to check them...) so it's good to give the user control over when it should be run, and remove duplication.

Motivation and Context

HERA validation sims.

Types of changes

Checklist:

For all pull requests:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.42%. Comparing base (65940bc) to head (b1438c8). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #503 +/- ## =========================================== - Coverage 100.00% 98.42% -1.58% =========================================== Files 11 11 Lines 2157 2157 =========================================== - Hits 2157 2123 -34 - Misses 0 34 +34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.