Open steven-murray opened 2 days ago
Attention: Patch coverage is 66.66667%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 99.80%. Comparing base (
6ea6af1
) to head (92bcd91
).
Files with missing lines | Patch % | Lines |
---|---|---|
src/pyuvsim/mpi.py | 66.66% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
This is great! The myriad part of pyuvdata doesn't work on Windows, so that's why those break.
Description
This adds
psutil
to the dependencies for the[sim]
extra, and moves the import ofresource
/psutil
into the only function that uses it. This means that Windows can now run sims.Note that some tests still fail on windows (e.g. using miriad files). I haven't dug deep into it, but we could try putting xfails on thins we know will fail and start testing against windows if we want. For now, this update means all matvis tests pass on windows.
Motivation and Context
In testing matvis against pyuvsim, I was trying to use the GPU, and on my laptop that's easier to do on Windows. I found that the pyuvsim comparison tests broke on Windows however, simply because of the import of
resource
, which is unix-only. This fixes it.Types of changes
Checklist:
For all pull requests:
Build or continuous integration change checklist: