search

Radiokot / photoprism-android-client

📸 A convenient Android gallery for your PhotoPrism library with plenty of useful features
https://radiokot.com.ua/p/photoprism-android-gallery
GNU General Public License v3.0
391 stars 30 forks source link

Added french translation #120

Closed vhaudiquet closed 7 months ago

vhaudiquet commented 7 months ago

This commit adds a french translation to the app.

Thank you for your awesome work !

Radiokot commented 7 months ago

Good evening, Valentin, thank you for your submission! Please, complete the translation, fix the problems and then notify me, so I could complete the review. I'd be happy to include your work into the app, but it is not yet ready. Here are some screenshots with problems:

vhaudiquet commented 7 months ago

Hi, I think I fixed all of my mistakes, sorry for that.

However, I don't know where the text 'Normal/Slow/...' from your last screenshot comes from. It does not seem to be in the 'string' value file. Is it a system string that is wrong because of your test environment, or something I should find in another file ?

Thank you for your time

Radiokot commented 7 months ago

The speed and size enums are string arrays among other strings. Take a look at the default (English) strings: https://github.com/Radiokot/photoprism-android-client/blob/2af8ece50cd6bfbc96c63a7bfc0a0935af0fdc4e/app/src/main/res/values/strings.xml#L151-L168

vhaudiquet commented 7 months ago

Interesting, the Android Studio string editor does not show them. I modified the file by hand, this should do it. Thank you for your time !