search

Radiokot / photoprism-android-client

📸 A convenient Android gallery for your PhotoPrism library with plenty of useful features
https://radiokot.com.ua/p/photoprism-android-gallery
GNU General Public License v3.0
391 stars 30 forks source link

App missing from android TV store #66

Open ippocratis opened 1 year ago

ippocratis commented 1 year ago

That's not an issue really I can still sideload the app just mentioning it

Radiokot commented 1 year ago

What is the store on your TV? The app should appear in Google Play, but I haven't added it to Samsung/LG/other stores.

ippocratis commented 1 year ago

What is the store on your TV? The app should appear in Google Play, but I haven't added it to Samsung/LG/other stores.

It is Google's playstore but the apps there are limited to apps only working on tv's

I think the Dev needs to opt in the app for android TV https://developer.android.com/training/tv/publishing/distribute

Not really sure

It's not that important really as the app sideloads fine

just wanted to mention the fact

On the other hand maybe its a valid reason to expand the userbase

Media server Apps are common in televisions

Radiokot commented 1 year ago

Turned out, that in order for the app to be shown in Google Play TV, after enabling the TV compatibility and uploading TV screenshots, I had to put an extra checkmark 🤯
I did it, now they will review the app and hopefully make it visible. Thank you for reporting ❤️

Radiokot commented 1 year ago

So they declined the publication because there was no app name on the TV banner and the welcome screen looked too "portrait" to them. I've updated the banner and split the welcome screen into 2 columns. Will resubmit with the next release. I think they might pick on search view, which can't be opened from keyboard – I've added an alternative message shown only on TVs suggesting using a mouse. Will see 🙄 @linosgian

Radiokot commented 1 year ago

How do you sideload the app to a TV? Does it require cable connection to a computer, or you just download and install the APK from the internal browser?

ippocratis commented 1 year ago

How do you sideload the app to a TV?

You could use a shared network folder. I used an app called send files to TV instead.

linosgian commented 1 year ago

I used built the apk, dumped it on a usb stick, and used a file manager app on the android TV to install it

Radiokot commented 1 year ago

They declined publication again: image

Now, I really have no idea what they mean by "vertical letterboxing", so I made an appeal to have a conversation with a real person.

ippocratis commented 1 year ago

I had no idea pushing the app to android TV store will be such demanding. Anyway I think what they mean is some ui elements might be hidden/overlaping/overscaned as the app is designed for portrait mode and not landscape.

Maybe this answer will give you some hints: https://stackoverflow.com/a/64270885

I think letterboxing are the black bars on the adge of the screen when the content is not flitting the screen aspect ratio(?)

https://developer.android.com/guide/practices/enhanced-letterboxing

Radiokot commented 1 year ago

They explained what they mean by "vertical letteboxing". Are you ready? 😂

your app (version code 26) contains videos that are not displayed in full screen.

So they logged into the PhotoPrism demo, opened 4:3 photos and 9:16 vertical videos, saw the horrible black bars on the left and right sides and rejected the publication.

image

Seems like Google folks don't care at all which app they review and think that every app for Android TV must be Netflix-like movie player. They suggested adding a ridiculous disclaimer to the Google Play app description saying "you'll see content in its original aspect ratio in this app". I did it and now they will make another review with the next app update.

sharky98 commented 1 year ago

I saw on the official PhotoPrism that this app worked on Android TV and was sad to not find it. I am happy to see that this is a WIP (but PITA coming from Google side). Don't give up!

I did not test the app yet, but maybe adding a setting for auto rotation, auto zoom (fill viewscreen). Not sure how feasible it is, but could help with Google reviewers?

Radiokot commented 1 year ago

Rejected again 🥴

Your app requires user interaction for menus or app navigation. Please make sure that menus and app navigation needed for the app’s core functionality are fully functional using a DPad.

I think they mean Search, so the "Search the library (use the mouse)" hint did not help. I asked them if I can put another disclaimer to the app description or simply hide the search bar on TV. There is no way I will get the search to work with DPad, too much effort is required to do and support it.

ippocratis commented 1 year ago

Just don't include the app on the TV store too much trouble for questionable profit

rrednaxela commented 12 months ago

How do you sideload the app to a TV?

You could use a shared network folder. I used an app called send files to TV instead.

I installed it using adb. You need to enable USB debugging on the TV, and then you can install it over network using adb connect <IP> adb install file.apk

GlassedSilver commented 11 months ago

Rejected again 🥴

Your app requires user interaction for menus or app navigation. Please make sure that menus and app navigation needed for the app’s core functionality are fully functional using a DPad.

I think they mean Search, so the "Search the library (use the mouse)" hint did not help. I asked them if I can put another disclaimer to the app description or simply hide the search bar on TV. There is no way I will get the search to work with DPad, too much effort is required to do and support it.

Aren't there boilerplate screen keyboards that you can use?

I have a hard time believing you have to reinvent the wheel here.

In any case I find it odd to suggest to the user to hook up a mouse to their TV to use the most basic feature this app can provide after viewing stuff. Am I way off here? My remote has a BT mic, using it in YT and other apps successfully, same with the screen keyboard in various apps for short searches.

Radiokot commented 11 months ago

@GlassedSilver believe it or not – maintaining keyboard navigation (movable focus) is ridiculously hard with components designed to be used on touch screen, such as Material Design 3 search bar. I am not Google, I can neither afford to maintain a different version of the app for TVs nor to write and support endless tweaks to make the keyboard navigation work with touchscreen components.

GlassedSilver commented 11 months ago

Maybe @photoprism themselves can pitch in some effort since you're making this app to support their ecosystem?

ippocratis commented 11 months ago

Maybe @photoprism themselves can pitch in some effort since you're making this app to support their ecosystem?

Their Dev team is limited. Their feature requests countless. They have a prioritization system on feature requests based on donations. They heavily rely on pull requests. But yeah true maybe shining this issue on their discussions maybe hopefully bring a pull request here.