Cannot exit selection mode

[jvadair]

What is wrong? Once a photo has been selected, you cannot exit selection mode without closing the application.

To Reproduce Steps to reproduce the behavior:

1. Open the application
2. Hold tap on a photo
3. Try to click the 'X' button on the bottom
4. See error

Expected behavior The application should exit selection mode

Screenshots

Device (please complete the following information):

• Model: OnePlus Nord N20 5G
• Android version: 12
  • System language: Italian (but I am a native English speaker)
  • Location: USA

Additional context I installed the latest version from F-droid today.

[Radiokot]

Hi James. You can exit the mode by making the "Back" gesture. But I agree that the "X" button behavior is unintuitive and should be changed.

[jvadair]

Thanks for fixing this! To clarify, does a long press exit the selection mode or clear the selection?

Personally, I feel it would be more intuitive to clear and exit the selection when the button is pressed, as there is no reason to remain in selection mode if there are no selections, nor is there any reason to keep things selected when not in selection mode.

I may also have read the commit wrong, if the long press mentioned refers to the action used to initiate selection mode.

[Radiokot]

Clicking the "X" button will exit the selection mode, if the selection mode is started by a long press on gallery item. There is another way to get into the selection mode – when the gallery is started by some other app to pick content. In this case "X" works as before.

[Radiokot]

The change is included to the latest release