RadiusNetworks / flybuy-android

FlyBuy SDK for Android
Other
5 stars 0 forks source link

SDK shouldn't provide any dependency in alpha version #17

Closed hatched-mariusz closed 1 year ago

hatched-mariusz commented 1 year ago

It is hidden problem cased by com.google.maps:google-maps-services dependency.

In version com.radiusnetworks.flybuy:pickup:2.7.0 you update the com.google.maps:google-maps-services dependency from version 2.0 to version 2.1 and com.google.maps:google-maps-services:2.1.0 added a new dependency: com.squareup.okhttp3:okhttp:5.0.0-alpha.7 because in my application I using com.squareup.okhttp3:okhttp:4.9.3

Now I'm getting runtime errors - HTTP-400. It is important to don't introduce in SDK alpha dependencies. Now I can exclude okhttp group from pickup like that:

api ('com.radiusnetworks.flybuy:pickup') // If using pickup feature
    {
        exclude group: "com.squareup.okhttp3", module: "okhttp"
    }

but I'm not sure how much com.google.maps:google-maps-services dependency base on okhttp and if I will not get another runtime error. Please back to com.google.maps:google-maps-services:2.0.0 or use 2.1.0 but exclude okhttp dependency and test your sdk, or take version 2.6.3 and merge the solution for concurrent modification exception and generate version 2.6.4

botnerd commented 1 year ago

It looks like this was fixed in Google Maps Services SDK v2.1.1. We're working on an update to bump that dependency version.

hatched-mariusz commented 1 year ago

Glad U find a solution Please generate a new build because this issue generates for Us the most crashes:

Screenshot 2022-12-09 at 09 10 33

BTW we took a risk and excluded okhttp group from lib, and it is working.

botnerd commented 1 year ago

We will have an update out soon for the okhttp library version. The ConfigManager crash in the screenshot was fixed in 2.7.3. Please update to that version and let us know if you have any additional issues.

botnerd commented 1 year ago

This has been fixed in the 2.7.4 release. If you run into any issues, let us know.