search

Raelzaryn / RPG-Hud

40 stars 32 forks source link

Changing Item in main hand while holding food in off hand causes crash #6

Closed thephoenixlodge closed 7 years ago

thephoenixlodge commented 7 years ago

https://pastebin.com/9R8f2dFp Found with 3.5.2, as yet have not had the chance to test with 3.6+ Seems to be somewhat inconsistent, first time it was encountered was with pineapples from Plants, then with Peaches from Terraqueous, yet then didn't crash with vanilla apples. Has been observed to occur when changing item simply by scrolling across the hotbar, and by placing the held item (specifically observed with a jungle wood boat)

ADeathlyTouch commented 7 years ago

I was able to replicate by simply switching steak into my off hand and scrolling. Happened almost instantly and honestly surprised me how easy it was to replicate. This was done moments ago using version 3.6.1

Raelzaryn commented 7 years ago

I'll take a look tomorrow (3am here). If I can find the problem (should be easy enough) I'll release the fix probably 1-2h later

Raelzaryn commented 7 years ago

Found the issue (crash when holding food in off hand while having less than maximum hunger and having no item in the main hand). I didn't properly check for that case. It's fixed now. Just gotta wait for curse to accept and check the 3.6.2 version.

PS: Please report any bugs you find (I have no testers for the mod and I simply dont have the time to test it much) so I have to rely on users to report bugs. You got my word I'll try to fix the bugs as soons as possible (usually the same or enxt day)