search

RafaGago / mini-async-log

Non bloated asynchronous logger
Other
221 stars 20 forks source link

Compilation fixes for gcc 4.9.1 #3

Closed Bklyn closed 9 years ago

Bklyn commented 9 years ago

Fixes required to compile without warnings on gcc 4.9.1. Please excuse my Emacs' habit of removing trailing whitespace.

RafaGago commented 9 years ago

Hello,

Thanks for the effort, unfortunately I can pull some of the changes.

I guess that the printf format warnings may be caused because you are compilating x64 targets, so the data types change. If I would these changes the warnings would appear when compiling for x86.

As Microsoft guys don't support C99 style printf in Visual Studio 2010 I can't target specific data types.

I'll open a bug for these warnings. A proper patch would involve detecting the architecture at /util/system.hpp and then #ifdef those blocks.

I have fixed the thread header and the missing includes.

RafaGago commented 9 years ago

See this:

https://github.com/RafaGago/ufo-log/issues/4

Thanks for reporting!

Bklyn commented 9 years ago

Right you are about the architecture. I see various libraries define macros for the printf format string to use for various types. See for example https://github.com/hpc/cce-mpi-openmpi-1.4.4/blob/master/opal/include/opal_stdint.h