RafaelBarbosatec / bonfire

(RPG maker) Create RPG-style or similar games more simply with Flame.
https://bonfire-engine.github.io
MIT License
1.22k stars 188 forks source link

[Bug]: Typo error BarLifeDrawPorition should be BarLifeDrawPosition #515

Closed pertusatti22 closed 4 months ago

pertusatti22 commented 4 months ago

What happened?

Has been a while I want to develop some games, and bonfire helping me a lot with! While watching the series of Tower Defense, I noticed this typo error and thinking it a good way to start my contribution.

I clone the repo and try to figure it out and send a PR, and at your disposal to start contributing. Thanks again for bonfire.

Regards!

Steps to reproduce?

1. Create some attackable
2. setup LifeBar
3. barLifeDrawPosition

setupLifeBar(barLifeDrawPosition: BarLifeDrawPorition.bottom);

What did you expect to happen?

setupLifeBar(barLifeDrawPosition: BarLifeDrawPosition.bottom);

Bonfire version

3.8.7

Relevant log output

No response

pertusatti22 commented 4 months ago

The fix was done, just don't have permission, Waiting for contact __ Commit message fix: correct typo in BarLifeDrawPorition to BarLifeDrawPosition (#515)

How


Can't create a new pull request: Push failed: remote: Permission to RafaelBarbosatec/bonfire.git denied to pertusatti22. unable to access 'https://github.com/RafaelBarbosatec/bonfire.git/': The requested URL returned error: 403

RafaelBarbosatec commented 4 months ago

Thanks so much for this reporting! Available in the version 3.9.0