RafaelKa / node-serialport-enocean-parser

ESP3 parser for nodes serialport
Do What The F*ck You Want To Public License
6 stars 2 forks source link

Add class for Radio_Sub_Tel #14

Closed Holger-Will closed 6 years ago

Holger-Will commented 6 years ago

tracking bug #12

Holger-Will commented 6 years ago

What is this supposed to mean? i don't get how the sub-tel group should be organized. from my understanding the offset calculation does not make any sense... shouldn't it be

is it:

Tick_SubTel_1 dBm SubTel_1 Status SubTel_1 Tick_SubTel_2 dBm SubTel_2 Status SubTel_2

or:

Tick_SubTel_1 Tick_SubTel_2 dBm SubTel_1 dBm SubTel_2 Status SubTel_1 Status SubTel_2

screenshot_20181203_054845

Holger-Will commented 6 years ago

i have implemented it like this:

Tick_SubTel_1 dBm SubTel_1 Status SubTel_1 Tick_SubTel_2 dBm SubTel_2 Status SubTel_2

this makes more sense, and the wording gives hints at this being the intentional structure.

Holger-Will commented 6 years ago

fixed with #25