decoupling ESP3 parsing from ESP3 Typed parsing

RafaelKa / node-serialport-enocean-parser

ESP3 parser for nodes serialport

Do What The F*ck You Want To Public License

6 stars 2 forks source link

decoupling ESP3 parsing from ESP3 Typed parsing #25

Closed Holger-Will closed 6 years ago

Holger-Will commented 6 years ago

have a second parser that inherits from simple ESP3Parser and which is able to parse ESP3Packets by type.

Holger-Will commented 6 years ago

this way we can export multible parsers for all needs. the second parser could live in a second repository though...

RafaelKa commented 6 years ago

can you rebase, please

Holger-Will commented 6 years ago

this is what 1.0.0 could look like. We have a test coverage of 100%, packet detection and packet type parsing is properly decoupled, all ERP3 Packet types are implemented, and we have standard coding style in place. I think the naming convention is readable and consistent. The only thing that is not yet in this branch is logging.

Holger-Will commented 6 years ago

fix #14 #17 #18 #19 #20