search

RafaelKa / node-serialport-enocean-parser

ESP3 parser for nodes serialport
Do What The F*ck You Want To Public License
6 stars 2 forks source link

TypeError on Node v. <0.12 #4

Closed Holger-Will closed 7 years ago

Holger-Will commented 8 years ago

i think this is in your module, can you take a look at this?

https://github.com/Holger-Will/node-enocean/issues/15

RafaelKa commented 8 years ago

References: Buffer.checkInt() @ v0.11

Buffer.checkInt() @ v0.12

Possible Fixes:

  1. Resolve and set offset on ESP3Packet.getRawBuffer::dataLengthBuffer.writeInt16BE(this.header.dataLength, 0)
  2. Skip value and offset validation ESP3Packet.getRawBuffer::dataLengthBuffer.writeInt16BE(this.header.dataLength, 0, true)
  3. Set minimal engine v. to 0.12

For my Info: Breaking point is on Node v0.11.3

Holger-Will commented 8 years ago

My vote goes to 3. 0.11 times are long gone and a security risk anyways... it's good to break the old engines so people upgrade...

RafaelKa commented 8 years ago

@Holger-Will see https://github.com/nodejs/LTS#lts-schedule 0.12 maintaining ends in dec. 2016 What do you think about your node-enocean smallest engine version?

Holger-Will commented 8 years ago

probably 4.x...