search

RafalWilinski / express-status-monitor

🚀 Realtime Monitoring solution for Node.js/Express.js apps, inspired by status.github.com, sponsored by https://dynobase.dev
https://dynobase.dev/
MIT License
3.6k stars 257 forks source link

Package breaks with non-vulnerable Socket.Io version 4.1.2 #175

Open monizb opened 3 years ago

monizb commented 3 years ago

When socket-io is upgraded to the latest non-vulnerable version 4.1.2 the status monitor package breaks all the routes

Error:

 TypeError: this.server.adapter(...) is not a constructor
    at Namespace._initAdapter (/Users/monish/Dropbox/My Mac (Monish’s MacBook Pro)/Desktop/DockIntern/backend/node_modules/express-status-monitor/node_modules/socket.io/dist/namespace.js:40:24)
lamweili commented 2 years ago

I don't think there is a commit for socket.io@4.1.2. I'm using express-status-monitor@1.3.4 which upgraded to socket.io@4.4.1 with no issues.