Raffaello / sdl2-hyper-sonic-drivers

'90s sound-cards hardware emulation and files processing.
Apache License 2.0
5 stars 0 forks source link

PCMDriver forward tracks being played #282

Closed Raffaello closed 1 year ago

Raffaello commented 1 year ago

Summary by CodeRabbit

coderabbitai[bot] commented 1 year ago

[!WARNING]

Rate Limit Exceeded

@Raffaello has exceeded the limit for the number of files or commits that can be reviewed per hour. Please wait 13 minutes and 19 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the @coderabbitai review command. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per repository. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between c4181ab6e4a23e9b1fb702100bc43d5b19a01994 and 6ae2ce94947331af3cb61d17b2dd375b644ee66e.

Walkthrough

The changes primarily focus on the introduction of a forward function across various classes in the HyperSonicDrivers namespace, allowing for the advancement of the playback position in the audio stream. Additionally, an optimization is made in the sound.cpp file, and a new test case is added for the ms_toPos function. The project version is also updated in the CMakeLists.txt file.

Changes

File Path Change Summary
.../HyperSonicDrivers/utils/sound.cpp Optimized calculation by replacing division with bitwise shift. Introduced ms_toPos function.
.../HyperSonicDrivers/audio/IAudioStream.hpp Added commented-out forward function.
.../HyperSonicDrivers/audio/streams/PCMStream.cpp Introduced forward function.
.../HyperSonicDrivers/audio/streams/PCMStream.hpp Introduced forward function.
.../HyperSonicDrivers/drivers/PCMDriver.cpp Added include directive for "sound.hpp". Introduced forward function.
.../HyperSonicDrivers/drivers/PCMDriver.hpp Introduced forward function.
.../HyperSonicDrivers/utils/sound.hpp Introduced ms_toPos function.
.../HyperSonicDrivers/test/utils/TestSound.cpp Added ms_toPos test case.
.../HyperSonicDrivers/audio/PCMSound.hpp Removed append function.
.github/workflows/sonarcloud.yml Modified GitHub Actions workflow file.
CMakeLists.txt Updated project version and description.

Poem

🎵 With a hop, skip, and a jump, we move forward in the stream, 🐇💨

No more waiting, no more pause, like a dream within a dream. 🌙✨

Celebrating this day in history, with code that's clean and lean, 🎉💻

Oh, what a joy it is to code, in the season of the evergreen! 🌲🍂


Tips ### Chat with CodeRabbit Bot (`@coderabbitai`) - If you reply to a *review comment* from CodeRabbit, the bot will automatically respond. - To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment - Note: Review comments are made on code diffs or files, not on the PR overview. - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Note: For conversation with the bot, please use the review comments on code diffs or files. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json`
sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication