search

Raffaello / sdl2-vga-terminal

SDL2 VGA Terminal
MIT License
6 stars 1 forks source link

[azure-pipelines] build matrix #111

Closed Raffaello closed 4 years ago

Raffaello commented 4 years ago

to be triggered manually...

codecov[bot] commented 4 years ago

Codecov Report

Merging #111 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #111   +/-   ##
=======================================
  Coverage   81.63%   81.63%           
=======================================
  Files           2        2           
  Lines         294      294           
=======================================
  Hits          240      240           
  Misses         54       54

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c78af53...a072502. Read the comment docs.

todo[bot] commented 4 years ago

how to verify?

mocks and call some private method once?

https://github.com/Raffaello/sdl2-vga-terminal/blob/a072502e6401191f929ef6f19bca74638d2948d2/sdl2-vga-terminal/test/tests.cpp#L97-L102

This comment was generated by todo based on a TODO comment in a072502e6401191f929ef6f19bca74638d2948d2 in #111. cc @Raffaello.
todo[bot] commented 4 years ago

how to verify without mocking?

only with mocking at the moment i have a solution but require some restructure...

https://github.com/Raffaello/sdl2-vga-terminal/blob/a072502e6401191f929ef6f19bca74638d2948d2/sdl2-vga-terminal/test/tests.cpp#L111-L116

This comment was generated by todo based on a TODO comment in a072502e6401191f929ef6f19bca74638d2948d2 in #111. cc @Raffaello.
todo[bot] commented 4 years ago

how to verify without mocking?

only with mocking at the moment i have a solution but require some restructure...

https://github.com/Raffaello/sdl2-vga-terminal/blob/a072502e6401191f929ef6f19bca74638d2948d2/sdl2-vga-terminal/test/tests.cpp#L126-L131

This comment was generated by todo based on a TODO comment in a072502e6401191f929ef6f19bca74638d2948d2 in #111. cc @Raffaello.
todo[bot] commented 4 years ago

how to verify without mocking?

only with mocking at the moment i have a solution but require some restructure...

https://github.com/Raffaello/sdl2-vga-terminal/blob/a072502e6401191f929ef6f19bca74638d2948d2/sdl2-vga-terminal/test/tests.cpp#L137-L142

This comment was generated by todo based on a TODO comment in a072502e6401191f929ef6f19bca74638d2948d2 in #111. cc @Raffaello.
todo[bot] commented 4 years ago

_defaultChar_t consideration

this test might bring the consideration to return/have something different

https://github.com/Raffaello/sdl2-vga-terminal/blob/a072502e6401191f929ef6f19bca74638d2948d2/sdl2-vga-terminal/test/tests.cpp#L148-L153

This comment was generated by todo based on a TODO comment in a072502e6401191f929ef6f19bca74638d2948d2 in #111. cc @Raffaello.
Raffaello commented 4 years ago

Codacy Here is an overview of what got changed by this pull request:


Issues
======
- Added 2

Clones added
============
- sdl2-vga-terminal/test/tests.cpp  2

See the complete overview on Codacy

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Raffaello commented 4 years ago

Codecov Report

Merging #111 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #111   +/-   ##
=======================================
  Coverage   81.63%   81.63%           
=======================================
  Files           2        2           
  Lines         294      294           
=======================================
  Hits          240      240           
  Misses         54       54

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c78af53...a072502. Read the comment docs.

the bot reported wrongly there is a codecov increase on codecov site is displaying that...