search

Raffaello / sdl2-vga-terminal

SDL2 VGA Terminal
MIT License
6 stars 1 forks source link

[ci | testing ] enable snapshot testing #141

Closed Raffaello closed 4 years ago

Raffaello commented 4 years ago

in windows, and try fix in macOS..

the macOs in CI, probably also due to software rendering, has a different pixel format for the loaded image SDL_PIXELFORMAT_BGRA32

i think it can be ignored that expectation, at the same time i have no way to reproduce it... and puzzled why a loaded image should have a different format.

This could also lead to a different palete, colors, in macOS, but again i cannot really test without a mac.... but should not as it is the loaded image that as a different expect format, when it is the constant here in the text.

as a quick solution i can just comment out that expected test line.

Raffaello commented 4 years ago

unfortunately the screen is black when doing the test on macOS... like is not rendered in time. i am doing the last test adding 1s delay between the render method and checks.

Raffaello commented 4 years ago

maybe with even more than 1s would work, but i won't do that... so this wontfix