V0.4

[Raffaello]

• [x] add test for all write methods that should output the same result
• [x] add test for all writeXY methods that should output the same result

[todo[bot]]

define an operator to simply this expression

what is compared here is the terminalchar_t not the _terminalChar_t rendered flag in this case is ignored.

---

https://github.com/Raffaello/sdl2-vga-terminal/blob/deced7f14205c286e0a42332de735d1334c91953/sdl2-vga-terminal/src/VgaTerminal.cpp#L580-L585

---

This comment was generated by todo based on a TODO comment in deced7f14205c286e0a42332de735d1334c91953 in #158. cc @Raffaello.

[codecov[bot]]

Codecov Report

Merging #158 into master will decrease coverage by 2.27%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
- Coverage   90.90%   88.63%   -2.28%     
==========================================
  Files           5        5              
  Lines         374      387      +13     
==========================================
+ Hits          340      343       +3     
- Misses         34       44      +10     

Impacted Files	Coverage Δ
sdl2-vga-terminal/src/VgaTerminal.cpp	90.78% <0.00%> (-3.15%)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b81e84f...71399ec. Read the comment docs.

[todo[bot]]

major version refactor to a struct

instead of having first and second have a struct with x, y.

---

https://github.com/Raffaello/sdl2-vga-terminal/blob/a182537e6d2ba05e9ecbcbe26eb594b94a4463a5/sdl2-vga-terminal/src/VgaTerminal.hpp#L36-L41

---

This comment was generated by todo based on a TODO comment in a182537e6d2ba05e9ecbcbe26eb594b94a4463a5 in #158. cc @Raffaello.

[todo[bot]]

this could be an "utility method" itself

consider to create in VgaTerminal class an operator/method to implement the same functionality here. Probably, not just the same if want to keep the fine element level checks like below.

---

https://github.com/Raffaello/sdl2-vga-terminal/blob/71399ec33a6ddc4d57a689ee1026f58a9e6ff4c8/sdl2-vga-terminal/test/VgaTerminalTest.cpp#L11-L16

---

This comment was generated by todo based on a TODO comment in 71399ec33a6ddc4d57a689ee1026f58a9e6ff4c8 in #158. cc @Raffaello.

[todo[bot]]

this could be an "utility method" itself

consider to create in VgaTerminal class an operator/method to implement the same functionality here. Probably, not just the same if want to keep the fine element level checks like below.

---

https://github.com/Raffaello/sdl2-vga-terminal/blob/71399ec33a6ddc4d57a689ee1026f58a9e6ff4c8/sdl2-vga-terminal/test/VgaTerminalTest.cpp#L23-L28

---

This comment was generated by todo based on a TODO comment in 71399ec33a6ddc4d57a689ee1026f58a9e6ff4c8 in #158. cc @Raffaello.

[Raffaello]

Here is an overview of what got changed by this pull request:

Clones removed
==============
+ sdl2-vga-terminal/test/VgaTerminalTest.cpp  -2

See the complete overview on Codacy

[sonarcloud[bot]]

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
1 Code Smell

0.0% Coverage
0.0% Duplication

The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more here