newline and fix consistency on read methods.

Raffaello / sdl2-vga-terminal

SDL2 VGA Terminal

MIT License

6 stars 1 forks source link

newline and fix consistency on read methods. #16

Closed Raffaello closed 4 years ago

Raffaello commented 4 years ago

bonuses:

[x] refactor unit tests
[x] remove code duplication in a self contained file without over-engineering.
[x] resetViewport method implementation
[x] add a clear test

Raffaello commented 4 years ago

Here is an overview of what got changed by this pull request:


Clones removed
==============
+ sdl2-vga-terminal/test/tests.cpp  -8

See the complete overview on Codacy

Raffaello commented 4 years ago

there are some error in appveyor... some changes there?

Raffaello commented 4 years ago

there are some error in appveyor... some changes there?

looking at the history of the builds, there is a PATH problem detecting the right compiler, now is detcting GCC in strawberry path, when it was instead

The C compiler identification is MSVC 19.25.28610.4

ref: https://ci.appveyor.com/project/Raffaello/sdl2-vga-terminal/builds/32287327/job/4v434jrvw2pnm9xf

a quick dirty fix could be to remove GCC from the path.. ? but something weird on appveyor