search

Raffaello / sdl2-vga-terminal

SDL2 VGA Terminal
MIT License
6 stars 1 forks source link

DRY num cursors constant #43

Closed Raffaello closed 4 years ago

Raffaello commented 4 years ago

it has been in 3 different places.

Raffaello commented 4 years ago

it is not possible to fix it. has those 3 different values are for three different context and scope:

2 in fonts: 1 for defining the const in a C style the other in a C++ way (#define vs constexpr) could be dried up here and just use the C style one.

the other one is in the VgaTerminal class that has no visibility on the fonts at the header level, but just on the implementation and it is another constexpr.

so if it have to just DRY the one in the fonts header... can just be skipped at the moment.

not worth it.