Raffaello / sdl2-vga-terminal

SDL2 VGA Terminal
MIT License
6 stars 1 forks source link

V0.2.2 #66

Closed Raffaello closed 4 years ago

Raffaello commented 4 years ago

this PR complete v.0.2.2


the thread safety i am still considering... (this could be a ticket itself and honestly it should be a major version change probably.... need to consider it more at the time of writing 🤔 )

just for fun can be achieved, but won't be really the point of this lib, each terminal should have a dedicated thread, having multiple threads accessing to the same terminal, doesn't make too much sense too me at the moment, but .....

but could be interesting an use case which each thread might have a dedicated region on the terminal to write output there, (the render of course must be synchronized) ... in this case having the extra guarantee of thread-safe lib might be useful...

todo[bot] commented 4 years ago

export all the required methods

it has been done just the bare basic as a show case


https://github.com/Raffaello/sdl2-vga-terminal/blob/72f9bd4850822e6da8bdb1fce59aaca4741b6e34/sdl2-vga-terminal/include/vga-terminal.h#L2-L7


This comment was generated by todo based on a TODO comment in 72f9bd4850822e6da8bdb1fce59aaca4741b6e34 in #66. cc @Raffaello.
todo[bot] commented 4 years ago

review the user event

at the moment is just using `SDL_USEREVENT`, should be something more specific and unique.


https://github.com/Raffaello/sdl2-vga-terminal/blob/72f9bd4850822e6da8bdb1fce59aaca4741b6e34/sdl2-vga-terminal/src/VgaTerminal.cpp#L411-L415


This comment was generated by todo based on a TODO comment in 72f9bd4850822e6da8bdb1fce59aaca4741b6e34 in #66. cc @Raffaello.
Raffaello commented 4 years ago

since v0.2.2 aim to be thread-safe library

Raffaello commented 4 years ago

waiting for CI improvement before merging #69 alt text

Raffaello commented 4 years ago

waiting for CI improvement before merging #69 alt text

and #72 #73

Raffaello commented 4 years ago

missing #75

Raffaello commented 4 years ago

Codacy Here is an overview of what got changed by this pull request:


Clones added
============
- sdl2-vga-terminal/test/valgrind/multithreading.cpp  1

See the complete overview on Codacy