Raffaello / threedangles

3D triangles software rendering engine from scratch
MIT License
0 stars 0 forks source link

3d engine basics #3

Closed Raffaello closed 2 years ago

todo[bot] commented 2 years ago

doing rasterization later on.

https://github.com/Raffaello/threedangles/blob/9ece10f733d2452b4543ef8454b68c53a9c26037/threedangles/threedangles.cpp#L46-L51


This comment was generated by todo based on a TODO comment in 9ece10f733d2452b4543ef8454b68c53a9c26037 in #3. cc @Raffaello.
todo[bot] commented 2 years ago

compute FPS and display on Title/screen

also cap the Frame rate to VSYNC or 60


https://github.com/Raffaello/threedangles/blob/8890c73407997acfeaeee24a091b0594e025b94f/threedangles/threedangles.cpp#L111-L116


This comment was generated by todo based on a TODO comment in 8890c73407997acfeaeee24a091b0594e025b94f in #3. cc @Raffaello.
todo[bot] commented 2 years ago

review these dubplicated "destructors"

https://github.com/Raffaello/threedangles/blob/2c5788fe9d57ae8c9757d164c9840f9967198982/threedangles/threedangles.cpp#L109-L114


This comment was generated by todo based on a todo comment in 2c5788fe9d57ae8c9757d164c9840f9967198982 in #3. cc @Raffaello.
todo[bot] commented 2 years ago

store vt and vn values

https://github.com/Raffaello/threedangles/blob/6c36e3ba6d69b4bfe2aa08ff768acf604cf8a713/threedangles/src/Mesh.cpp#L38-L43


This comment was generated by todo based on a TODO comment in 6c36e3ba6d69b4bfe2aa08ff768acf604cf8a713 in #3. cc @Raffaello.
todo[bot] commented 2 years ago

review these dubplicated "destructors"

https://github.com/Raffaello/threedangles/blob/6c36e3ba6d69b4bfe2aa08ff768acf604cf8a713/threedangles/threedangles.cpp#L87-L92


This comment was generated by todo based on a todo comment in 6c36e3ba6d69b4bfe2aa08ff768acf604cf8a713 in #3. cc @Raffaello.
todo[bot] commented 2 years ago

remove as it has been deprecated

https://github.com/Raffaello/threedangles/blob/6a2bcc0bf045d2c8069a2dd143029144ea17b1e9/threedangles/src/Mesh.cpp#L3-L8


This comment was generated by todo based on a todo comment in 6a2bcc0bf045d2c8069a2dd143029144ea17b1e9 in #3. cc @Raffaello.
todo[bot] commented 2 years ago

these should be moved in Mat4x4 class

https://github.com/Raffaello/threedangles/blob/9f59d4d2e45b2dd8378b4dbf10c4bf44829334f4/threedangles/src/Engine.hpp#L9-L14


This comment was generated by todo based on a todo comment in 9f59d4d2e45b2dd8378b4dbf10c4bf44829334f4 in #3. cc @Raffaello.
lgtm-com[bot] commented 2 years ago

LGTM pull request analysis was skipped for 0c694fdf92896ac764b1fc34ff4d93aeddbf3217 by Raffaello. Analysis of future commits will happen as normal.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 128 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication