search

Rafostar / clapper

Level up your video experience with a modern and user-friendly media player.
https://rafostar.github.io/clapper/
GNU General Public License v3.0
791 stars 37 forks source link

Please consider applying for Gnome Circle #174

Open CleoMenezesJr opened 3 years ago

CleoMenezesJr commented 3 years ago

I think this nice little utility deserves some more exposure and recognition. It would also be interesting to apply the menu button on the right side instead of the left one, since it is not a toolbox type like Kooha or Contrast.

Examples of toolbox apps: image image

Following the HIG: image image

Congratulations on your work.

Rafostar commented 3 years ago

As far as HIG goes, an "Open" action button is usually (in every?) app on the left, while another menu button is on the right. Clapper had this simplified into a single menu button, and because an open new file is the most often used action in it, it ended up on the left where this action belongs.

TheOPtimal commented 3 years ago

On the note of moving buttons, I think the fullscreen and popup buttons are the ones that should be moved to the right. Like the close button, they are window related.

Rafostar commented 2 years ago

Please do not start an "applying for Gnome Circle" and "Reorder OSD buttons" discussion in the same issue. There are some :+1: here, and now I dunno for which of these 2 ideas people are voting for.

frandavid100 commented 2 years ago

There was some talk today regarding the possibility of replacing Totem with Clapper as Gnome's default video player. I imagined you might want to chime in.

CleoMenezesJr commented 2 years ago

I had seen, but I rarely saw anything really relevant. Nowadays I just hope Toten is ported to gtk4 and gets new features.

Rafostar commented 2 years ago

@frandavid100 I wasn't asked directly, so I am not gonna butt-in myself to their conversation. AFAIK gnome.org matrix rooms are configured to not display messages prior to joining, so no point for me to go there now anyway :smile:

@CleoMenezesJr You are free to like whatever you want of course. If you have any problems with Clapper that have led you to this conclusion you can open an issue on this github always. Otherwise please save your unpleasant remarks that do not belong here to yourself.

CleoMenezesJr commented 2 years ago

????? What unpleasant comment? And where did I complain about the project? It doesn't make any sense when I opened this ticket saying that I liked the project and that it would be nice if it were on GNOME Circle. The only thing I did was to answer @frandavid100 that there was no relevant conversation in the Matrix about Clapper replacing Toten as core app, and that I hoped it would be ported to GTK 4.

frandavid100 commented 2 years ago

@frandavid100 I wasn't asked directly, so I am not gonna butt-in myself to their conversation. AFAIK gnome.org matrix rooms are configured to not display messages prior to joining, so no point for me to go there now anyway

One participant said that Clapper could be a good choice to replace Totem, since it has excellent support for lots of formats out of the box, follows Gnome HIG and afaik is a ready-made product.

Another replied that it would need to properly follow the HIG, rename, move to GNOME infra and remove stuff like like its "super hacky" picture-in-picture that used mutter's private dbus api previously, and many of the preferences.

Anyway, there seemed to be some interest about the issue, so I figured you could be interested.

Rafostar commented 2 years ago

remove stuff like like its "super hacky" picture-in-picture that used mutter's private dbus api previously, and many of the preferences.

Just for the record, those "super hacky" Mutter/GNOME specific DBUS actions and related preferences were scheduled to be removed for next minor version anyway in order so I could finish #103 now that playback works there without issues.

frandavid100 commented 2 years ago

So, maybe once those are gone you can propose it to replace Totem?

Rafostar commented 2 years ago

So, maybe once those are gone you can propose it to replace Totem?

This isn't for me to decide, and I am in no position to propose/request anything like that. All I can promise you is that I definitely am NOT gonna drop this project no matter which path GNOME and Totem will take. We use different stuff here (more self/custom made), so Totem even if ported to GTK4 will not magically become Clapper. We already do some things that other players do not and there's much more cool stuff yet to come (both feature and performance wise).

frandavid100 commented 2 years ago

This isn't for me to decide, and I am in no position to propose/request anything like that.

I'll have to find out how to propose it, then, because having Clapper as Gnome's default video player would be awesome.

julianfairfax commented 10 months ago

In addition to joining Circle, it would also be nice if the app's code were moved to GNOME World. GitHub is not an open source platform, and being owned by Microsoft makes it more of a danger to open source projects, rather than a help.

Rafostar commented 6 months ago

@CleoMenezesJr

It would also be interesting to apply the menu button on the right side instead of the left one, since it is not a toolbox type like Kooha or Contrast.

This is now changed in latest version to be in the same place as in other apps, as you requested in this issue description.