search

Rafostar / clapper

Level up your video experience with a modern and user-friendly media player.
https://rafostar.github.io/clapper/
GNU General Public License v3.0
767 stars 35 forks source link

Move subtitles position vertically when controls bar appears #264

Open legacychimera247 opened 2 years ago

legacychimera247 commented 2 years ago

Well i noticed that when you move the mouse to see controls and the time bar, the bar overlaps subtitles, making them harder to read for a few seconds, wouldn't be nice to have a youtube like approach where in this particular case subtitles just move a little bit over the bar? Screenshot from 2022-05-22 13-58-25-1

Rafostar commented 2 years ago

Idea seems cool. Need to get rid of the old video sink first. There is gonna be a problem with some subtitle formats through (e.g. ASS) where position and dimensions are explicitly defined. Not sure yet if adding this functionality here or into GStreamer would be better.

legacychimera247 commented 2 years ago

oh that's good to hear, well i'm not in a hurry as anyway the player is already working fine, but still improvements are always welcomed...

nekohayo commented 9 months ago

In https://github.com/Rafostar/clapper/issues/97#issuecomment-1849008285 it was also mentioned that subtitle position should be dependent on image position and vice versa, to avoid them overlapping the image when fullscreened (or maximized, or resized) with a video's aspect ratio that is thinner than the screen.

I would suggest retitling this ticket here to reflect that additional usecase? Or should @sojusnik's ticket be retitled, or should the auto-positioning-based-on-aspect-ratio idea be its own ticket?

Rafostar commented 9 months ago

I would suggest retitling this ticket here to reflect that additional usecase? Or should @sojusnik's ticket be retitled, or should the auto-positioning-based-on-aspect-ratio idea be its own ticket?

97 is and should be about color only. This one is about automatic behavior which is related to position setting but not quite the same with description as-is.

I think there should be one more generic issue about adding "Different subtitle positioning options" or something like that. Either from this issue or a new one superseding this issue here where "bottom + auto move when UI is shown" is one of the possible options.