search

Rafostar / clapper

Level up your video experience with a modern and user-friendly media player.
https://rafostar.github.io/clapper/
GNU General Public License v3.0
717 stars 34 forks source link

[Feature Request] GNOME Dark/Light follow OS theme support #276

Open Cherro59 opened 2 years ago

Cherro59 commented 2 years ago

How about to make Clapper prefer dark/light theme which selected in GNOME Settings? I think it would be not hard to make it, when app already ported to libadwaita

Rafostar commented 2 years ago

The principle was always for media content related apps to use dark. Did this change now? At least according to GNOME HIG:

Applications can choose which of the two styles to use by default. They can also include a control to allow users to switch between the light and dark style, and they can select the light and dark style based on the system-wide UI style setting.

Most apps should use the standard light UI style by default. However, apps can alternatively choose to use the dark style by default instead. This is primarily recommended for apps which display rich visual content like images or video.

Thus we do just that, force dark by default and give an eventual option to switch to light in preferences window. Please note that OSD is always dark grayish (almost black) no matter which color is used, so using light mainly affects the bottom controls panel when not in fullscreen and eventual opened in app windows.

folknor commented 2 years ago

Perhaps the setting could be renamed to "Force Dark Theme", and when off the app follows the global settings?

Rafostar commented 2 years ago

First and foremost, considering we already have light/dark toggle, this feature request does not really say things like: Why is it needed? What issue following OS theme solves? What benefit it gives?

If this is gonna be actively requested, I would rather change this into one of multiple selection setting, with options:

Where "Dark" would be the default. But I am still unsure what the point of this change would be. Especially when most of the UI always stays dark (OSD) in every mode.

Rafostar commented 3 months ago

In the latest Clapper UI everything is now OSD. In OSD, elements are always dark regardless of theme set (thats just how GTK/Adwaita stylesheets are). I am not sure if this feature is needed anymore, since there is nothing left in the main app window to apply a light theme to.