Rafostar / clapper

Level up your video experience with a modern and user-friendly media player.
https://rafostar.github.io/clapper/
GNU General Public License v3.0
773 stars 36 forks source link

Option to render subtitles at screen resolution instead of video #321

Open forteller opened 1 year ago

forteller commented 1 year ago

I drag and dropped some .srt subtitles into Clapper, and they where almost unreadable:

image

For some reason it doesn't look too terrible in this screenshot, but I think that's because it's a full screen screenshot showed as a much smaller picture. In reality it's really bad.

As a comparison, here's how the exact same subtitles looks when drag and dropped into Celluloid instead: image

Version 0.5.2, installed via Flathub, on Nobara Linux.

Thanks for your great work! :)

Rafostar commented 1 year ago

It's not a bug, it's a feature :laughing:. No, but seriously, subtitles are rendered at video resolution (on purpose), so they do not look completely out of place (and more like the text that might be part of video) when watching SD quality on higher resolution screen. This can be observed on you screenshots when zoomed/displayed at 1x scale.

The result varies depending on how low of a resolution you are watching your video. This is a personal preference. We would need to add an option to render them at screen resolution.

forteller commented 1 year ago

Huh. That… doesn't make sense to me 😅 Sorry!

I'm sure you have a good reason, but no matter if I watched the video in a small window or in full screen the subtitles where just as useless to me, and looked much worse than the quality of the video. So at least in this one instance I felt it did look out of place. Though I see your point that the higher quality subtitles might look even more out of place, I just don't see why that matters. Subtitles are just a practical thing, and, sure, they should also look ok, but function must come first, IMO.

Anyways, thanks for the fast reply and trying to explain :D And thanks for accepting this as a feature request :)

ghost commented 1 year ago

Isn't your personal preference just an overall worse way to do it? What are the advantages of that approach? As far as I can see that seems to be just lower quality text rendering.

lisiczka43 commented 1 year ago

I for one don't mind subtitles being rendered at video resolution, although it seems that default style for .srt files have really thin outline, even on 1080p, and scaled to SD it looks even thinner. Maybe make outline slightly bolder by default to avoid obfuscating UI with settings?

mpv: Screenshot from 2023-06-02 22-22-15

Clapper: Screenshot from 2023-06-02 22-22-04