search

Rafostar / clapper

Level up your video experience with a modern and user-friendly media player.
https://rafostar.github.io/clapper/
GNU General Public License v3.0
714 stars 34 forks source link

Touchpad gesture to scrub timeline is imprecise #340

Closed kdwk closed 2 months ago

kdwk commented 1 year ago

Problem

Currently, users can use two-finger swiping with a touchpad to scrub the timeline. However, since this doesn't utilize 1:1 finger tracking, the scrubbing doesn't stick to the fingers, making the scrubbing too imprecise to be useful.

Proposal

I propose to either use 1:1 finger tracking for timeline scrubbing or disable this touchpad gesture.

Rafostar commented 2 months ago

I think this works nicely now. Although I currently tested only on a single touchpad.

kdwk commented 2 months ago

Unfortunately trackpad scrubbing does not seek the timeline anymore. The position marker would move to track my fingers, but when I release it will jump right back to the original position, and not perform the seek.

Rafostar commented 2 months ago

Ah, then I misinterpreted this issue. What I meant that was implemented is the more precise seeking by doing two finger horizontal scroll gesture with the touchpad anywhere on the video. The gesture to perform scrubbing on the progress bar itself is indeed missing.

Rafostar commented 2 months ago

@kdwk Can you check if #404 fixes this issue here (you can build from branch or simply download Flatpak artifact)?

Please note that, what we are doing is fixing "two-finger swiping" on either video or seek/progress bar to seek into more precise position. We are not implementing actual "scrubbing" (seeking while dragging) here yet (a separate issue for that already exists).

Rafostar commented 2 months ago

The MR fixed the not working scroll touchpad gesture on slider for me, thus merged. It now works like I explained in my previous comment here, but if you still experience problems or it doesn't work for you, feel free to reopen.