search

Rafostar / clapper

Level up your video experience with a modern and user-friendly media player.
https://rafostar.github.io/clapper/
GNU General Public License v3.0
713 stars 34 forks source link

Keyboard shortcut for Preferences dialog #365

Closed RedBearAK closed 4 months ago

RedBearAK commented 1 year ago

Please add a keyboard shortcut binding to open the Preferences dialog.

It has become somewhat common on GNOME apps to use Ctrl+comma for opening preferences, so that is what I will suggest as the shortcut. This echoes the Cmd+comma that works in most macOS apps, and the Shift+Ctrl+comma that is used in a number of KDE apps that I've used.

I use a keymapper config that mimics the keyboard behavior of macOS in Linux desktop environments, so I could potentially remap my "Cmd+comma" shortcut to anything for this application, but there has to be some kind of keybinding in place to map onto. If the shortcut was Ctrl+comma it would "just work", like in other GTK apps I use, such as Text Editor.

Rafostar commented 4 months ago

This was added in: https://github.com/Rafostar/clapper/commit/058844c01045f8b1981cb1171126b9293953a364

RedBearAK commented 4 months ago

@Rafostar

Tried to test on the Flatpak version of Clapper that I have installed on Fedora 39, but it looks like the Flatpak version needs to be updated. It's still 0.5.2 here and on Flathub, and there is no shortcut assigned to the Preferences menu item in the hamburger menu.

Rafostar commented 4 months ago

@RedBearAK

The shortcut was added hence issue closed, but there is no stable release version with it yet.