Rafostar / clapper

Level up your video experience with a modern and user-friendly media player.
https://rafostar.github.io/clapper/
GNU General Public License v3.0
711 stars 34 forks source link

RTL Support for Subtitles #423

Open mrostd opened 2 months ago

mrostd commented 2 months ago

I have noticed an issue with the subtitle display. Clapper does not correctly display right-to-left (RTL) text in subtitles. This is particularly problematic for languages such as Arabic, Persian, and Hebrew. The text appears to be displayed left-to-right (LTR), which makes the subtitles difficult to read and understand.

Rafostar commented 2 months ago

A video sample to work with + screenshots how it looks and how its supposed to would be helpful.

There was a new Clapper version released recently, but since its sink that renders them (and it was not part of this release work) I suspect that this is NOT a new issue, just nobody reported this earlier.

mrostd commented 2 months ago

Sure! On the right side, the rtl text is arranged correctly. Screenshot from 2024-04-24 18-36-58 Screenshot from 2024-04-24 18-38-25

Rafostar commented 2 months ago

I assume these are muxed (contained in file) subtitles, yes? Or opened from external file? In case of muxed in video, can you share some short/small video file or a cut part of it where issue happens?

mrostd commented 2 months ago

Subtitles are external. However, I have put a rtl subtitle file here, you can import it into a video file. 3. Interstellar.2014.BluRay.NightMovie.zip

fawaz006 commented 1 day ago

Same issue for me

Rafostar commented 1 day ago

Does these files with issues have affected lines displayed correctly when opened in a Pango-based text editor (GNOME Text Editor or Gedit)?

Rafostar commented 1 day ago

For me, they do not seem to be rendered correctly by Pango:

image

image