search

Rafostar / clapper

Level up your video experience with a modern and user-friendly media player.
https://rafostar.github.io/clapper/
GNU General Public License v3.0
711 stars 34 forks source link

Complement com.github.rafostar.Clapper.metainfo.xml #429

Closed 1Maxnet1 closed 1 month ago

1Maxnet1 commented 2 months ago

Based on what is already available in the LinuxPhoneApps listing I added some missing metainfo:

Rafostar commented 2 months ago

Hi, thanks for contributing to Clapper project.

The categories were recently removed from metainfo, as per: https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/#categories-and-keywords which says that they will be automatically pulled from .desktop file when building AppStream data and are not needed to be in metainfo file. Which (I at least think) happens and works correctly with Flathub (otherwise there should be an app-categories-missing warning split out, which I do not get):

Says: (...) defining them separately in the MetaInfo is not strictly necessary.

If you are absolutely sure these are actually needed to be there by something else, please put a comment above them for what, otherwise I am afraid that this can be forgotten and removed again at some later time during deprecated things cleanup.

1Maxnet1 commented 2 months ago

Hi, thanks for contributing to Clapper project.

The categories were recently removed from metainfo, as per: https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/#categories-and-keywords which says that they will be automatically pulled from .desktop file when building AppStream data and are not needed to be in metainfo file. Which (I at least think) happens and works correctly with Flathub (otherwise there should be an app-categories-missing warning split out, which I do not get):

Says: (...) defining them separately in the MetaInfo is not strictly necessary.

If you are absolutely sure these are actually needed to be there by something else, please put a comment above them for what, otherwise I am afraid that this can be forgotten and removed again at some later time during deprecated things cleanup.

Hey, thanks for the explanation,

at https://linuxphoneapps.org/ we have a check whether our App listings are up-to-date. So in a sense, we make use of the upstream categories, to check whether they fit the ones in our App listings. I am also aware that KDE needs this categories in their apps metadata, to make sure that they appear in the dedicated categories when published on F-Droid, however as your app is not distributed through F-Droid, this might not be relevant to you. I do not know whether there is a use case, that would make the categories relevant for you, so please let me know, if I should leave them out.

Rafostar commented 2 months ago

@1Maxnet1

So my understanding is that "linuxphoneapps" is using this very XML file to get the data by fetching it from app repo and parsing and not the generated later "AppStream Catalog XML" (which should have them from .desktop file), yes?

If that is the case, please just add a comment block above the categories saying that it's used by Linux phone apps.

1Maxnet1 commented 2 months ago

@1Maxnet1

So my understanding is that "linuxphoneapps" is using this very XML file to get the data by fetching it from app repo and parsing and not the generated later "AppStream Catalog XML" (which should have them from .desktop file), yes?

If that is the case, please just add a comment block above the categories saying that it's used by Linux phone apps.

Yes that's the case, thanks for the suggestion, I added it. Also there is a https://www.freedesktop.org/software/appstream/docs/re01.html make-desktop-file option in the official appstreamcli tool. Maybe it might also make sense to generate the desktop file from the metainfo.xml instead of adding the categories from the desktop-file to the metainfo.xml This way they would not be the need to duplicate them.

Rafostar commented 1 month ago

Thanks! LGTM