Rafostar / clapper

Level up your video experience with a modern and user-friendly media player.
https://rafostar.github.io/clapper/
GNU General Public License v3.0
711 stars 34 forks source link

Unsupported subtitle format leads to Clapper refusing to play the video entirely because of the "missing plugin" #440

Open nekohayo opened 1 month ago

nekohayo commented 1 month ago

If you download this file, archived from YouTube using VideoDownloader:

Annotating PDFs | Acrobat for Educators.webm

...and try to open it with the flatpaked (flathub) version of Clapper 0.6.0, then Clapper will completely refuse to play the file, even though subtitles are kind of optional:

bildo

Maybe it could special-case subtitle plugin types as being non-fatal if missing?

Troubleshooting information

Rafostar commented 1 month ago

For now, linking upstream issue if anyone wants to help fix them, so they will actually play: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1100

Maybe it could special-case subtitle plugin types as being non-fatal if missing?

While we could just quietly ignore them... but then nobody would know that his/her video is missing something. So this needs to be considered here too.

nekohayo commented 1 month ago

Maybe the error message in non-fatal cases could be shown as GtkOverlay widget, a bit like the completed copy in-app notifications in Nautilus and Calendar?