Rafostar / clapper

Level up your video experience with a modern and user-friendly media player.
https://rafostar.github.io/clapper/
GNU General Public License v3.0
720 stars 34 forks source link

Audio Skipping on ADPCM Codec .wav #470

Open stark-silence opened 1 week ago

stark-silence commented 1 week ago

I'm on Manjaro Gnome, AMD CPU, 6.6.34-1-MANJARO kernel, clapper 0.6.1 from the AUR.

I audibly heard what sounded like audio skipping on playback of a music track, so I took a quick recording, layered it on top of the original in Audacity and found that Clapper was seemingly randomly skipping small chunks of the file, like less than a second at a time, which adds up. It was only on this specific .wav type so I checked out the codec, and it turned out be specifically Microsoft ADPCM.

I could not reproduce the skipping in mpv, so I figured it must be an issue with clapper or something it uses. I went deeper and converted the .wav ADPCM to signed 16-bit PCM and then played that once again through clapper, recorded it, and put that back into Audacity, and on doing so found that it lined up 1:1, or in other words, it was not skipping anymore, so I am assuming it has 'something' to do with clapper's Microsoft ADPCM codec, or something.

I did try a different MS ADPCM file and had the same skipping problem so it is not localized just to one file. I then tried converting from 16-bit PCM back to MS ADPCM and that resultant file did NOT skip when played back by clapper... so...

It is still anomalous behavior but the specificity is weird. I'll just post this here anyway. For the sake of reproducing the issue, if you're curious about the specific files I'm having trouble with here, it's tracks from C&C Remastered, extracted from game files.

Pictured: Top - source file, middle - converted .wav, bottom - clapper's output recorded. Screenshot from 2024-07-02 20-56-37

Rafostar commented 1 week ago

Probably should be reported to GStreamer. Please check the name of audio decoder used (in "i" dialog).

Rafostar commented 4 days ago

Doesn't look like a Clapper bug, but if you can check which decoder is used we can try reproducing in GStreamer-only to confirm and also see if alternative decoder also does this.