search

Rafostar / clapper

Level up your video experience with a modern and user-friendly media player.
https://rafostar.github.io/clapper/
GNU General Public License v3.0
794 stars 37 forks source link

fix: adw 1.6 deprecations #479

Open GeopJr opened 3 months ago

GeopJr commented 3 months ago

Libadwaita 1.6 is around the corner so I migrated some dialogs to the non-deprecated versions:

AdwAboutWindow => AdwAboutDialog AdwMessageDialog => AdwAlertDialog

I also changed the uri-dialog's GtkEntry to AdwEntryRow to better match the HIG

image

My C is a bit rusty, let me know if I should change something or if I should split this PR into smaller ones!

Additionally, there's another change that should be done but it's a bit too much for me to do, the main window should become AdwWindow / AdwApplicationWindow to take full advantage of the dialogs. Those windows can display the dialogs inside of them instead of creating new ones and making them modals, which has the added bonus of the dialogs becoming bottom-sheets on narrow window sizes to better fit mobile devices

Rafostar commented 3 months ago

Thanks for PR! Since this is part of the application itself, I am kinda surprised you are contributing to something that Tuba doesn't use :wink:

I haven't looked closely at code yet, but one thing I think you might have missed is bumping minimal required libadwaita version in meson.

GeopJr commented 3 months ago

Since this is part of the application itself, I am kinda surprised you are contributing to something that Tuba doesn't use 😉

I 💖 Clapper!

I haven't looked closely at code yet, but one thing I think you might have missed is bumping minimal required libadwaita version in meson.

Done! I also bumped gtk's to libadwaita 1.5's minimum

Rafostar commented 2 months ago

Hi. Sorry for late reply (I was on vacation break last month). This PR looks good to me. Thanks!

Although, if its ok with you, I will hold it off for now until I have time to work on AdwWindow ports (as I am working on some other Clapper feature right now), since currently this causes criticals (https://gitlab.gnome.org/GNOME/libadwaita/-/issues/912).

There should be both this + AdwWindows in a single release of Clapper and I haven't decided yet if I will make a release before or after working on AdwWindow changes.