search

Rafostar / clapper

Level up your video experience with a modern and user-friendly media player.
https://rafostar.github.io/clapper/
GNU General Public License v3.0
794 stars 37 forks source link

Broken video playback if OpenGL is unavailable #497

Open City-busz opened 1 month ago

City-busz commented 1 month ago

The commit 681da9e2f39fd5180317113e7349272586ae645d breaks the video playback if OpenGL is not supported by the system, because it tries to use glsinkbin unconditionally.

Please either remove this workaround, or ensure that GL context is available before using glsinkbin.

Rafostar commented 1 month ago

Indeed. gst_element_factory_make will return glsinkbin if its installed regardless if we can realize GL context. But GStreamer 1.24 have broken playback without using it.

We probably gonna need a sink to be a bin that hotplugs GL elements only if possible...