Rafostar / gnome-shell-extension-pip-on-top

Makes "Picture-in-Picture" windows stay on top (even on Wayland session). Compatible with Firefox, but may work with few other browsers too.
GNU General Public License v2.0
53 stars 10 forks source link

Gnome Shell crashes when closing Brave PiP #15

Open jckso opened 1 year ago

jckso commented 1 year ago

When closing a PiP window from Brave, Gnome Shell crashes. --Jul 07 01:49:43 gnome-shell[2669]: ** Jul 07 01:49:43 gnome-shell[2669]: libmutter:ERROR:../src/core/window.c:1543:meta_window_unmanage: assertion failed: (g_list_find (workspace->windows, window) == NULL) Jul 07 01:49:43 gnome-shell[2669]: Bail out! libmutter:ERROR:../src/core/window.c:1543:meta_window_unmanage: assertion failed: (g_list_find (workspace->windows, window) == NULL) Jul 07 01:49:43 gnome-shell[2669]: == Stack trace for context 0x55b4d2c016d0 == --

Rafostar commented 1 year ago

What is your gnome-shell version? Does this stop happening when you disable this extension?

Scotty-Trees commented 1 year ago

Just came across this issue myself, but with Vivaldi. I have Firefox, Vivaldi, and Gnome Web installed and I interchange between using each of them, depending on my task at the time. I do have your latest PiP extension installed on Firefox and while using it on just Firefox, it functions fine. I'm on Fedora 38 Gnome, using Wayland. However, when I switch over to Vivaldi, which has built in PiP support via Chromium backend, and use the PiP in Vivaldi, once I click on that PiP to close it or pause it or anything, that's when the whole gnome shell crashes me out, logs me out, and kicks me back to the log in screen.

This is not an intended action of your extension I'm sure, but it is a catastrophic failure, so I've since disabled your extension. Feel free to let me know if you need any additional information from me to see if we can't solve this little issue.

stransky commented 7 months ago

Ah look like PIP crash from Firefox I just reported: https://github.com/Rafostar/gnome-shell-extension-pip-on-top/issues/22

Perhaps wrong workspace management?