Rafostar / gnome-shell-extension-pip-on-top

Makes "Picture-in-Picture" windows stay on top (even on Wayland session). Compatible with Firefox, but may work with few other browsers too.
GNU General Public License v2.0
53 stars 10 forks source link

Feature Request: Always on Visible Workspace #5

Closed maxlahn closed 2 years ago

maxlahn commented 2 years ago

Thanks so much for this great and useful extension! If possible, it would be really nice to be able to configure the extension to also set picture-in-picture windows to be workspace-independent -- the desired functionality is currently obtained by clicking the "Always on Visible Workspace" button in the right-click menu of the picture-in-picture window.

psydvl commented 2 years ago
Just use Win+Middle Mouse button to open this menu ![image](https://user-images.githubusercontent.com/43755002/175750509-5208f205-94f2-4477-8e20-609ec65fad93.png)
Rafostar commented 2 years ago

@psydvl

OP already mentioned that he knows Super + Right click menu. It should be plausible to have this configurable as an option, so there is one less manual user action needed.

psydvl commented 2 years ago

Oh, sorry, missread then Hmm, and Win+Right click allow you to resize any window instead of opening menu While simple Right click pause Clapper for me

Rafostar commented 2 years ago

Added config option to show on all workspaces.

maxlahn commented 2 years ago

Thank you so much!

Rafostar commented 2 years ago

The new extension version with this added option was uploaded to GNOME Extensions website. Option is configurable in settings window which was done using libadwaita as latest GNOME Shell (42 or later) requires.

If anyone here wants this behavior, but still uses older GNOME Shell version, then you can do following change to your current extension code:

diff --git a/extension.js b/extension.js
index e07b219..e1cc559 100644
--- a/extension.js
+++ b/extension.js
@@ -114,6 +114,7 @@ class PipOnTop

       window._isPipAble = true;
       window[`${un}make_above`]();
+      window[`${un}stick`]();
     }
   }
 }

Otherwise (on GNOME 42 or later) you just need to update the extension and enable this functionality in settings window. Maintaining multiple extensions versions for each GNOME Shell version in really hard. Thank you for understanding.