search

Rafostar / gnome-shell-extension-pip-on-top

Makes "Picture-in-Picture" windows stay on top (even on Wayland session). Compatible with Firefox, but may work with few other browsers too.
GNU General Public License v2.0
53 stars 10 forks source link

Mark as GNOME 43.alpha compatible #9

Closed emansom closed 2 years ago

emansom commented 2 years ago

Works without a hitch in GNOME 43.alpha. No errors nor warnings reported in logs. Workspace toggle tested and works as well.

Using FCGU repo and AUR package gnome-shell-extension-pip-on-top43 to test.

Schermafdruk van 2022-07-14 23-31-22

Rafostar commented 2 years ago

Please correct me if I am wrong, but doesn't API/ABI freeze happen for 43.beta? If so, we cannot really tell if extension will end up being 43 compatible. According to extensions guidelines:

Extensions must not claim to support future GNOME Shell versions

Although extension metadata might contain up to one development release e.g: "43.alpha" as shown in their example.

I can either hold off this MR until GNOME Shell API/ABI freeze happens or we can change it into "Mark as GNOME 43.ALPHA compatible" with updated commit message and metadata to "43.alpha" and merge it now. Decision is yours.

emansom commented 2 years ago

Didn't know about the 43.alpha version label available to the metadata. Will update and rebase this PR accordingly later this day.

emansom commented 2 years ago

Done. 👍🏻

Rafostar commented 2 years ago

Thanks!