search

Rafostar / playercast

Cast to media player and control playback remotely.
GNU General Public License v3.0
114 stars 5 forks source link

Update media title from player #5

Closed bertwesarg closed 4 years ago

Rafostar commented 4 years ago

Hi, This might be useful for media-player-controller module, since that one is universal and can be used for making various node apps, but could you describe how playercast would benefit from implementing this (preferably with usage example)? Media title is already send in message and shouldn't change unless we cast another media (then new title is send and updated automatically from message).

bertwesarg commented 4 years ago

It is of tremendous usability when casting YT URLs. Without, you see in the client only the watch?v=ABC as the title. But mpv exracts the title from the URL and notifies the property change through IPC.

bertwesarg commented 4 years ago

Hi, This might be useful for media-player-controller module

Do you mean Rafostar/media-player-controller#3?

Rafostar commented 4 years ago

Do you mean Rafostar/media-player-controller#3?

Yes, I saw that so I wanted to ask about benefit of that in playercast.

It is of tremendous usability when casting YT URLs. Without, you see in the client only the watch?v=ABC as the title.

OK. That would be indeed useful. Since media title is also kept in other variables for other various purposes (e.g. keeping track of playlist item number), please test if this change would not break switching media items (videos) when casting either few local videos or few youtube videos.

bertwesarg commented 4 years ago

OK. That would be indeed useful. Since media title is also kept in other variables for other various purposes (e.g. keeping track of playlist item number), please test if this change would not break switching media items (videos) when casting either few local videos or few youtube videos.

Already in heavy use here. Works as expected.