search

Rafostar / playercast

Cast to media player and control playback remotely.
GNU General Public License v3.0
108 stars 5 forks source link

Allow to pass additional arguments to the media play #6

Closed bertwesarg closed 4 years ago

bertwesarg commented 4 years ago

I need to run the playercast service with a specific mpv argument, so that YT-DL videos wont use the best video quality, which caused to much CPU load. Now there is the --player-args option to pass additional arguments to the player.

Rafostar commented 4 years ago

Please use ~/.config/mpv/mpv.conf file to achieve that.

MPV reads config from that file first then command line options (some that I had to preset in code) override that config (higher priority). This function was never implemented because it has a VERY big potential to breaking whole cast functionality by setting some cmd options. That is why user specific MPV config should be stored in mpv.conf file instead. Also launching with some cmd options each time would be a real pain to the user...

bertwesarg commented 4 years ago

Thanks for the suggestion. Though I still consider my user case valid, in case mpv is also used normaly from the command line. Because than, the options needed for playercast may contradict the mode of operation from the command line. Thus to be independent from the use from the command line it may still make sense to have different options.

Luckily mpv knows profiles inside the mpv.conf file. Thus I would like to suggest, that mpv is started always/optionally with the --profile=playercast (or some other name) argument and we document that playercast specific mpv arguments should be put into this profile? Unfortunately mpv exists, if the profile does not exists.

Rafostar commented 4 years ago

For now I will put this functionality on hold. Your use case is to restrict specific youtube codecs/resolution to play videos smoothly. You do not need player profiles to do that, because its not like mpv without playercast can play it smoothly anyway, so I do not see a reason to have this specific setting only for playercast and have laggy videos when using mpv normally without playercast...

Also please keep in mind that when new functionality is added it should be possible to use it in all supported media players (there might be more then 2 in the future). VLC as far as I know does not support player profiles and always uses config stored on system when it launches. That is why leaving machine specific options for user to manually configure inside player seems like best solution for the time being to me.

bertwesarg commented 4 years ago

I'm fine with this.