RageAgainstThePixel / ElevenLabs-DotNet

A Non-Official ElevenLabs RESTful API Client for dotnet

https://elevenlabs.io/?from=partnerbrown9849

MIT License

59 stars 19 forks source link

Allow to use the API without file system #25

Closed danielwinkler closed 1 year ago

danielwinkler commented 1 year ago

This PR is to allow the library without reading / storing audio files with samples from the file system. Instead, byte[] is used to send / receive data.

danielwinkler commented 1 year ago

overall good stuff!

Thanks for the contribution, just a little feedback :)

Hey, thanks for looking at this so quickly. I replied to your comments, just let me know how you would prefer it and I will try to change as quickly as possible. I also thought about overloading the existing names but then it would break backwards compatibility when a function is called with the default parameters.

danielwinkler commented 1 year ago

@StephenHodgson ping

StephenHodgson commented 1 year ago

So I've been pretty busy this week.

I'll set aside time this weekend.

StephenHodgson commented 1 year ago

@danielwinkler Sorry I didn't get back to it this weekend, but I am working on a new release with this in mind!

26

It will address recent API changes as well as making it simpler to get data directly and giving clients full autonomy of what to do with clip data.

Thanks for the PR! Please take some time to review the next release if you get a chance 💜

danielwinkler commented 1 year ago

Thanks @StephenHodgson I will check the PR for the release. Cheers daniel