RageAgainstThePixel / ElevenLabs-DotNet

A Non-Official ElevenLabs RESTful API Client for dotnet
https://elevenlabs.io/?from=partnerbrown9849
MIT License
59 stars 19 forks source link

Dubbing access #48

Closed austinbhale closed 4 months ago

austinbhale commented 4 months ago

Thank you for this project! I added in some dubbing functionality, since it's been launched for all price tiers in May

StephenHodgson commented 4 months ago

Thanks @austinbhale! I'll check it out shortly.

Only initial feedback is to revert back to .net6. I wanted to keep support for that until it reaches EOL

StephenHodgson commented 4 months ago

Also please check your tab settings. Should be 4 spaces.

StephenHodgson commented 4 months ago

Please revert all changes to .csproj files

austinbhale commented 4 months ago

Please revert all changes to .csproj files

Could we keep the added net8.0 framework though? I can revert the treat warnings as errors as well

StephenHodgson commented 4 months ago

Could we keep the added net8.0 framework though?

It will automatically be supported with net6.0 reference.

https://www.nuget.org/packages/ElevenLabs-DotNet/#supportedframeworks-body-tab

austinbhale commented 4 months ago

I gotcha, keeping it compatible for net8.0 like that sounds good. Just wanted to take advantage of perf updates to the CLR, but prob no noticeable difference here

austinbhale commented 4 months ago

One more thing is I'll make a test for an online URL since that's supposed to work too

StephenHodgson commented 4 months ago

I gotcha, keeping it compatible for net8.0 like that sounds good. Just wanted to take advantage of perf updates to the CLR, but prob no noticeable difference here

When your actual project targets .net 8 it should update the CLR automatically

austinbhale commented 4 months ago

Ok it works for online content too! I should be done making changes until your testing & review :) Feel free to edit anything & swap out the YouTube video, I just chose theirs randomly

StephenHodgson commented 4 months ago

looks great. My only real Change Request is to make any return types from StartDubbingAsync a defined object.

Similar to VoiceClip

austinbhale commented 4 months ago

Thanks for the suggestion! I think that looks much cleaner for deserialization too

austinbhale commented 4 months ago

Hi! Any updates on integrating this?

StephenHodgson commented 4 months ago

Sorry been a bit busy. Working on some other edits as well but got overloaded with work.

Overall looks good and I'll get this in as soon as I finish up adding the other endpoints for sfx

austinbhale commented 4 months ago

Awesome, looking forward to trying those out. No rush, can use a private NuGet till then. Thanks!

StephenHodgson commented 4 months ago

@austinbhale You didn't give me edit access to your PR so I wasn't able to sync it with development, so I merged it into a new branch and opened a new PR #50