RageAgainstThePixel / com.rest.elevenlabs

A non-official Eleven Labs voice synthesis client for Unity (UPM)
https://elevenlabs.io/?from=partnerbrown9849
MIT License
74 stars 9 forks source link

Consider moving away from top menu #33

Closed nehvaleem closed 10 months ago

nehvaleem commented 10 months ago

As Unity discourages exploiting top level menu I would recommend putting the EvelenLabs dashboard under Tools/ or something similar.

Creating new top level menu items is discouraged by Unity. Imagine if every package that you used created their own menu. It would be total chaos.

I would totally love that. I am using this package in my project which already has too many items at the top level, and Unity's inability to give us the control to (re)move existing items is the only downside to using this package.

StephenHodgson commented 10 months ago

Thanks for bringing us up. I was actually planning on putting it in windows/dashboards/<package> for all my existing packages

nehvaleem commented 10 months ago

Anywhere besides a top level will be considered as a win from my perspective. About windows/dashboards/<package> - well it is your choice, but I have a more package-first oriented approach.

If you ever want to add something besides the dashboard window for your package either your package menu items will be scattered all over the place or it won't maintain its logical sense (ie. settings window for a package under window/dashboards, or package/tool settings menu item nested under one menu item and dashboard under window/dashboards).

Of course, the choice is yours in the end. I mostly care about not bloating the top level.

StephenHodgson commented 10 months ago

All of my packages have a settings entry in the project settings.

nehvaleem commented 10 months ago

the "settings" might not be the best example, as the project settings section fits it perfectly. Nevertheless I am happy that you are considering moving away from the top-level :)