search

Raghwendra-Dey / productivity_meter

Productivity meter for measuring productivity of solving problems
https://raghwendra-dey.github.io/productivity_meter/
MIT License
13 stars 23 forks source link

Notification Function Added #100

Open ghost opened 3 years ago

ghost commented 3 years ago

fixes #27

@Raghwendra-Dey Please check now..

Raghwendra-Dey commented 3 years ago

Hey @urvashi-code1255 your playSound function is working fine, but I couldn't find the breakDur variable, when I wrote it in the dev console. I think you missed some commits, could you have a look at it.

ghost commented 3 years ago

@Raghwendra-Dey actually when I was accepting the incoming changes in the merge conflict then after accepting them all the js variables were broken. So, I didn't accept those. That's why some things are not there..

Raghwendra-Dey commented 3 years ago

Okay, once check thoroughly, maybe more things are broken then.

ghost commented 3 years ago

Okay sir I will check and modify it tomorrow

ghost commented 3 years ago

@Raghwendra-Dey Please check now..

ghost commented 3 years ago

@Raghwendra-Dey ........

Raghwendra-Dey commented 3 years ago

Hey @urvashi-code1255 theres some issues with the average time thing. Recently we implemented a feature, where if we do a -1 the avg time would track the same path which it followed. For eg: lets say you are doing +1 continuously with some time difference. and your avg follows this path: 2, 4, 5, 6, 8, 10 secs If at 10 secs you do a -1 it should get reverted to 8 secs, if again -1 is pressed it should come to 6 secs, and like that. But its not happening with your patch. Please have a look. And sorry for the late review, I was a bit busy in the past days.