search

Raghwendra-Dey / productivity_meter

Productivity meter for measuring productivity of solving problems
https://raghwendra-dey.github.io/productivity_meter/
MIT License
13 stars 23 forks source link

Pop-up message #21

Closed kri-bhawna closed 3 years ago

kri-bhawna commented 3 years ago

We can let a pop-up message to appear whenever there will be any increment/decrement in the number of problems solved. This pop-up message can be featured to fade away automatically after a certain duration of time, say 5 sec.
For increment we can use "Well done ! keep it up!" , and for decrement "Oops! you've got an extra problem to solve!".

Raghwendra-Dey commented 3 years ago

Also please add a pop up message for the Go button proposed in the diagram given in #20 . Maybe something like, The clock is ticking, hurry up!!

Raghwendra-Dey commented 3 years ago

@kri-bhawna would you like to work on it?

kri-bhawna commented 3 years ago

@Raghwendra-Dey Sure, I can do that.

Raghwendra-Dey commented 3 years ago

@kri-bhawna please consider adding the error message pop-up of #24 , after its assignee is done with it. I believe that won't take long, so, for the time being consider working for the problem counter thing only. Also make the pop-up similar to what happens when we hover over #24 above in github.

kri-bhawna commented 3 years ago

Screenshot (20) Screenshot (19)

@Raghwendra-Dey Sir, please give your reviews regarding this format of the pop-ups to be displayed when +1 and -1 are clicked.

kri-bhawna commented 3 years ago

@Raghwendra-Dey These pop-ups will be displayed for 3 seconds(including the fade away time) and will fade away after that. These are displayed at the bottom right of the screen, in order to avoid any distraction for the user. Also, I was thinking to add an alert which will be displayed if problem count is 0 and user clicks -1. Alert having the text "You are already at problem count zero." This alert can be displayed on the top of the screen, as it needs attention of user. Please, give your feedback regarding this.

Raghwendra-Dey commented 3 years ago

Yeah these notification things are nice, but keep them small and also add a cross option in the top right, so that the user can cancel the things by clicking em. Just like its there in codeforces.com . Yeah, you can add this thing for the alreat as well. I don't think it would be good to change the position of the notification. But still prepare the demo for both, we'll see later.

kri-bhawna commented 3 years ago

@Raghwendra-Dey In reference to https://github.com/Raghwendra-Dey/productivity_meter/issues/21#issuecomment-739836245 Can you please clarify this ? I am not getting when actually do the pop up box has to appear for Go button, as per mentioned in above comment in #21 itself.

Raghwendra-Dey commented 3 years ago

@kri-bhawna for now, you just add them for +1, -1 and reset buttons

kri-bhawna commented 3 years ago

@Raghwendra-Dey Sir, I am done with +1,-1 and reset . Can I create a pull request for that?

Raghwendra-Dey commented 3 years ago

@kri-bhawna please post the photos here once.

kri-bhawna commented 3 years ago

Screenshot (21) Screenshot (22) Screenshot (23) Screenshot (24)

kri-bhawna commented 3 years ago

@Raghwendra-Dey I have added the cross icon in all of these, and it is having the hover effect of of red color. Also, have added the transition effect of fade off with different time intervals. Also, as per instructed previously I have reduced their sizes . Please give your feedback.

Raghwendra-Dey commented 3 years ago

@Raghwendra-Dey I have added the cross icon in all of these, and it is having the hover effect of of red color. Also, have added the transition effect of fade off with different time intervals. Also, as per instructed previously I have reduced their sizes . Please give your feedback.

Hey @kri-bhawna they look great!! Please raise a PR, and I would review the changes and merge it afterwards.