Raghwendra-Dey / productivity_meter

Productivity meter for measuring productivity of solving problems

https://raghwendra-dey.github.io/productivity_meter/

MIT License

13 stars 23 forks source link

Update HTML, JS, CSS and Remove scroll bar from todolist #59

Closed Vishal-raj-1 closed 3 years ago

Vishal-raj-1 commented 3 years ago

Description

Update HTML

Adding Heart Icon & remove heart emoji And fixes #58
Remove Inline styling And Fixes #57
Give Class for timer, label, controls, hh, mm, ss. And Fixes #56
Remove scrollbar from Todo list, Now it Will appear only when required And Fixes #53
Add Missing

tag

Update CSS

Remove style from footer <a> and Fixes #60
Remove overflow-y: auto from todo container and it is not required. It is required in todo list.

Update JavaScript

Remove querySelectorAll(......)[0]. instead of that we can use querySelector()

@Raghwendra-Dey Sir, Review this PR. And don't forget to give your valuable feedback.

Thanks & Regards Vishal

Raghwendra-Dey commented 3 years ago

Hey @Vishal-raj-1 thanks for working on checking validation sanity on the codebase. Please center the TODO text and Add button in todo list. Like its currently is.

Vishal-raj-1 commented 3 years ago

Please center the TODO text and Add button in todo list. Like its currently is. Sure !!

Vishal-raj-1 commented 3 years ago

@Raghwendra-Dey Check Now!!

Raghwendra-Dey commented 3 years ago

@Raghwendra-Dey Check Now!!

Also center the problem counter block. Its buttons and the text alignment.

Vishal-raj-1 commented 3 years ago

@Raghwendra-Dey It's done

Raghwendra-Dey commented 3 years ago

@Vishal-raj-1 Should I merge it, or you want to make any further changes?

Vishal-raj-1 commented 3 years ago

@Vishal-raj-1 Should I merge it, or you want to make any further changes?

Merge this !! I will work on other issues

Vishal-raj-1 commented 3 years ago

Thank you for merging @Raghwendra-Dey 🔥