search

Raghwendra-Dey / productivity_meter

Productivity meter for measuring productivity of solving problems
https://raghwendra-dey.github.io/productivity_meter/
MIT License
13 stars 23 forks source link

Updated pop_up_message #68

Closed kri-bhawna closed 3 years ago

kri-bhawna commented 3 years ago

@Raghwendra-Dey I have checked things from my side and found them working well. Please let me know if you also find everything well. Sorry for the inconvenience.

Raghwendra-Dey commented 3 years ago

Thank you @kri-bhawna for resolving the issues with the last PR.

Raghwendra-Dey commented 3 years ago

@kri-bhawna could you explain what was the mistake, which was breaking the average time feature. #46 is also having the same issues, maybe be helpful to resolve this thing there as well.

kri-bhawna commented 3 years ago

@Raghwendra-Dey While checking my js code with the master branch, I found two lines were missing in my js file. On adding them, things started working perfectly. Maybe I deleted those lines by mistake or maybe I haven't used the most updated js code. These are the two possibilities.

Raghwendra-Dey commented 3 years ago

@kri-bhawna what were those two lines?

kri-bhawna commented 3 years ago

@Raghwendra-Dey if(isrunningAverage) {updateAverage(cnt);} 212 and 213 line no. of script.js

Raghwendra-Dey commented 3 years ago

@kri-bhawna Thank you!