TodoList and Record Button is Styled

Raghwendra-Dey / productivity_meter

Productivity meter for measuring productivity of solving problems

https://raghwendra-dey.github.io/productivity_meter/

MIT License

13 stars 23 forks source link

TodoList and Record Button is Styled #73

Closed ghost closed 3 years ago

ghost commented 3 years ago

fixes #32 fixes #54

ghost commented 3 years ago

@Raghwendra-Dey Sir Please review this PR.

Raghwendra-Dey commented 3 years ago

Hey @urvashi-code1255 , thats a great work. The Todo List LGTM. But there seems to be some issues with the record thing.

It is supposed to be purple when off and blue when on right? But if you start it then its initally purple, but then once you make it blue by starting the recording, then if you stop, its not changing to purple.
after pressing reset the record button turns completely white, which seems abnormal.

Rest seems to be okay, please have a look at these bugs.

ghost commented 3 years ago

@Raghwendra-Dey sir, I have corrected it, please check now.

Raghwendra-Dey commented 3 years ago

Hey @urvashi-code1255 , the reset button changing from blue to purple when turned off is yet not okay, could you have a look at that. Press the record button to start recording, then switch it off, now you can't see the purple color, which should be signifying the off state.

ghost commented 3 years ago

Done @Raghwendra-Dey Sir now please check

Raghwendra-Dey commented 3 years ago

Hey @urvashi-code1255 I think theres some confusion. Theres still the same problem with the record button. The record button currently shows blue color when ON and white when OFF. After your patch, its supposed to be showing purple when OFF and blue when ON, along with the hovering effect and hovering color of white(You may remove the hovering color change of white, thats not that necessary). But the problem is, Its intially showing purple, which it should be, since its OFF initially. but when I turn it ON, and it turns blue, then if I again turn it OFF, its not again getting converted to purple, which it should have been, instead, its showing blue always, no matter it is ON or OFF.

ghost commented 3 years ago

@Raghwendra-Dey Please check now...

ghost commented 3 years ago

@Raghwendra-Dey On my end It was Like when it is off then purple, on hover its white, when its on then blue and when again clicking to make it off then purple. Now, I have removed the hover effect.

Raghwendra-Dey commented 3 years ago

Oh crap! again its something to do with firefox, and chrome thing. Working on chrome, but not on firefox. Please have a look what can be done. Tip: always check you feature atleast on these two famous browsers.

ghost commented 3 years ago

@Raghwendra-Dey I have addressed the problem background property was not working on firefox. I have changed it to backgroundColor. Now its working on both browsers on my side. Please check now :)

Raghwendra-Dey commented 3 years ago

Good work @urvashi-code1255 .