Corrected the average time calculator

Raghwendra-Dey / productivity_meter

Productivity meter for measuring productivity of solving problems

https://raghwendra-dey.github.io/productivity_meter/

MIT License

13 stars 23 forks source link

Corrected the average time calculator #90

Closed rsriramc closed 3 years ago

rsriramc commented 3 years ago

PRs related/ Issues related

Closes #89

Work done

Displayed the +1 and -1 buttons only while the recording window is live, else they are not displayed

Screen shots

When record is pressed

Raghwendra-Dey commented 3 years ago

Hey @ravisrc theres some problem with your patch. The changes after https://github.com/Raghwendra-Dey/productivity_meter/pull/86 is not showing in your patch. Please have a look.

rsriramc commented 3 years ago

Are my changes not coming, or the changes made in the PR #86 not coming after my patch?

I can't see any such changes that did not show up.

Raghwendra-Dey commented 3 years ago

changes made by #86 not coming.

rsriramc commented 3 years ago

They changes were there, Try removing a problem, then the avg is set to prev value

Raghwendra-Dey commented 3 years ago

No, its not working. Try it once again. You can also checkout the script.js file of the main repo and your this branch. The main repo contains the deque class and all. But your patch doesn't have them.

rsriramc commented 3 years ago

Yeah that's true but wont merging work?