search

RagnarGrootKoerkamp / BAPCtools

Tools for developing ICPC-style programming contest problems.
GNU General Public License v3.0
49 stars 22 forks source link

changed gitignore handling #347

Closed mzuenni closed 7 months ago

mzuenni commented 7 months ago

305

mpsijm commented 7 months ago

Thanks for simplifying the implementation, but I think I still don't like having (redundant) .gitignore files in the root of my problem directory :sweat_smile: I think we need more opinions here :stuck_out_tongue:

mzuenni commented 7 months ago

it should be easy to change now ^^ (as long as the gitignore stays in the problem folder). I just hope that i found all places that needed a change

mpsijm commented 7 months ago

it should be easy to change now ^^ (as long as the gitignore stays in the problem folder).

But it's not easy to change when I don't have a .gitignore file in my problem folders, and BAPCtools keeps regenerating it :sweat_smile:

mzuenni commented 7 months ago

I meant it should be easy to change the code if we decide for the self ignoring gitignore in /data.

RagnarGrootKoerkamp commented 7 months ago

I also like putting this in the problem .gitignore. Indeed it's a bit redundant but I agree it's more a problem than a contest setting, and anyway these files are automatically generated so there is little overhead. Also, adding problem/.gitignore is a clear indication to the user that we are ignoring the generated cases, since this file will be part of git status and then be committed. A self-ignoring problem/data/.gitignore is much more hidden to the user, and they may be surprised why cases are not being comitted.

So this settles A1 and B2 from #305. That only leaves the cleanup of unknown-file handling (C).